Refactor admin routes to use new AppError struct in responses

src/routes/admin/posts.rs

@@ -1,7 +1,7 @@
 use crate::{
     authentication::AuthenticatedUser,
     idempotency::{IdempotencyKey, save_response, try_processing},
-    routes::{AdminError, enqueue_delivery_tasks, insert_newsletter_issue},
+    routes::{AdminError, AppError, enqueue_delivery_tasks, insert_newsletter_issue},
     startup::AppState,
     templates::MessageTemplate,
 };
@@ -38,7 +38,7 @@ pub async fn create_post(
     }): State<AppState>,
     Extension(AuthenticatedUser { user_id, .. }): Extension<AuthenticatedUser>,
     Form(form): Form<CreatePostForm>,
-) -> Result<Response, AdminError> {
+) -> Result<Response, AppError> {
     validate_form(&form).map_err(AdminError::Publish)?;
 
     let idempotency_key: IdempotencyKey = form
@@ -65,16 +65,14 @@ pub async fn create_post(
         .await
         .context("Failed to enqueue delivery tasks.")?;
 
-    // Send emails with unique identifiers that contains link to blog post with special param
-    // Get handpoint that returns the post and mark the email as opened
-
     let template = MessageTemplate::Success {
         message: "Your new post has been saved. Subscribers will be notified.".into(),
     };
     let response = Html(template.render().unwrap()).into_response();
-    save_response(transaction, &idempotency_key, user_id, response)
+    let response = save_response(transaction, &idempotency_key, user_id, response)
         .await
-        .map_err(AdminError::UnexpectedError)
+        .map_err(AdminError::UnexpectedError)?;
+    Ok(response)
 }
 
 #[tracing::instrument(
@@ -116,5 +114,6 @@ pub async fn create_newsletter(
     content: &str,
     _post_id: &Uuid,
 ) -> Result<Uuid, sqlx::Error> {
+    // We need to send a special link with a unique ID to determine if the user clicked it or not.
     insert_newsletter_issue(transaction, title, content, content).await
 }