From ac96b3c249db8e64df3b4eaf790fbca25a06fafb Mon Sep 17 00:00:00 2001 From: Alphonse Paix Date: Sat, 27 Sep 2025 19:59:04 +0200 Subject: [PATCH] spans in logs --- src/issue_delivery_worker.rs | 3 --- src/telemetry.rs | 13 +++++++++++-- 2 files changed, 11 insertions(+), 5 deletions(-) diff --git a/src/issue_delivery_worker.rs b/src/issue_delivery_worker.rs index fba0783..bd3e218 100644 --- a/src/issue_delivery_worker.rs +++ b/src/issue_delivery_worker.rs @@ -126,7 +126,6 @@ impl NewsletterIssue { } } -#[tracing::instrument(skip_all)] async fn get_issue( connection_pool: &PgPool, issue_id: Uuid, @@ -152,7 +151,6 @@ pub struct Task { pub kind: String, } -#[tracing::instrument(skip_all)] async fn dequeue_task( connection_pool: &PgPool, ) -> Result, Task)>, anyhow::Error> { @@ -180,7 +178,6 @@ async fn dequeue_task( } } -#[tracing::instrument(skip_all)] async fn delete_task( mut transaction: Transaction<'static, Postgres>, issue_id: Uuid, diff --git a/src/telemetry.rs b/src/telemetry.rs index dc63ad3..4fe0894 100644 --- a/src/telemetry.rs +++ b/src/telemetry.rs @@ -1,5 +1,9 @@ use tokio::task::JoinHandle; -use tracing_subscriber::{fmt::MakeWriter, layer::SubscriberExt, util::SubscriberInitExt}; +use tracing_subscriber::{ + fmt::{MakeWriter, format::FmtSpan}, + layer::SubscriberExt, + util::SubscriberInitExt, +}; pub fn init_subscriber(sink: Sink) where @@ -15,7 +19,12 @@ where .into() }), ) - .with(tracing_subscriber::fmt::layer().pretty().with_writer(sink)) + .with( + tracing_subscriber::fmt::layer() + .pretty() + .with_writer(sink) + .with_span_events(FmtSpan::NEW | FmtSpan::CLOSE), + ) .init(); }